marvell: drivers: correct RTC init sequence
authorMarcin Wojtas <[email protected]>
Mon, 30 Jul 2018 08:18:45 +0000 (10:18 +0200)
committerKonstantin Porotchkin <[email protected]>
Mon, 3 Sep 2018 12:47:01 +0000 (15:47 +0300)
It turned out that resetting the RTC time register is not
necessary during initial configuration. Safely remove it
from the sequence.

Change-Id: Id2b9c7db44a8c8dbe88a7f8a21695b72a7fd78ee
Signed-off-by: Marcin Wojtas <[email protected]>
Reviewed-by: Nadav Haklai <[email protected]>
Reviewed-by: Kostya Porotchkin <[email protected]>
drivers/marvell/mochi/cp110_setup.c

index c4cb307f9b737b8f0754f03822d6c4663afd95e9..654bb62b2d1a33aa4a3a6221196bbfb0b8af16a0 100644 (file)
@@ -341,10 +341,6 @@ static void cp110_rtc_init(uintptr_t base)
                mmio_write_32(base + MVEBU_RTC_TEST_CONFIG_REG, 0);
                mdelay(500);
 
-               /* Reset Time register */
-               mmio_write_32(base + MVEBU_RTC_TIME_REG, 0);
-               udelay(62);
-
                /* Reset Status register */
                mmio_write_32(base + MVEBU_RTC_STATUS_REG,
                              (MVEBU_RTC_STATUS_ALARM1_MASK |
@@ -361,10 +357,6 @@ static void cp110_rtc_init(uintptr_t base)
                mmio_write_32(base + MVEBU_RTC_CCR_REG,
                              MVEBU_RTC_NOMINAL_TIMING);
 
-               /* Reset Time register */
-               mmio_write_32(base + MVEBU_RTC_TIME_REG, 0);
-               udelay(10);
-
                /* Reset Status register */
                mmio_write_32(base + MVEBU_RTC_STATUS_REG,
                              (MVEBU_RTC_STATUS_ALARM1_MASK |